Unhide auth logout and add traceability comments#4719
Open
mihaimitrea-db wants to merge 2 commits intomainfrom
Open
Unhide auth logout and add traceability comments#4719mihaimitrea-db wants to merge 2 commits intomainfrom
mihaimitrea-db wants to merge 2 commits intomainfrom
Conversation
The auth logout feature (PRs #4613, #4616, #4647) was squashed into a single commit cb3c326 titled after #4647 only, losing traceability for the new command itself. This followup: - Adds a comment block to logout.go linking each original PR with its commit range and purpose. - Adds a NEXT_CHANGELOG entry for auth logout under CLI. - Removes Hidden: true so the command appears in help and completion. - Aligns the Long description with the public documentation.
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 94ff659
16 interesting tests: 7 KNOWN, 7 SKIP, 2 flaky
Top 20 slowest tests (at least 2 minutes):
|
mihaimitrea-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cmd/auth/logout.golinking to the three original PRs (Add auth logout command with --profile and --force flags #4613, Add interactive profile picker to auth logout #4616, Extract shared SelectProfile helper to eliminate duplicate profile pickers #4647) and their commit ranges. These PRs were inadvertently squashed into a single commitcb3c326titled after Extract shared SelectProfile helper to eliminate duplicate profile pickers #4647 only.NEXT_CHANGELOG.mdentry forauth logoutunder the CLI section.Hidden: truefrom the logout command so it appears indatabricks auth -hand tab completion.databricks auth loginWhy
The
auth logoutfeature was implemented across three stacked PRs (#4613, #4616, #4647) that were squashed into one commit on merge. The commit title only references the last PR ("Extract shared SelectProfile helper"), soauth logoutitself has no changelog entry and no git-blame traceability.This followup restores that context, unhides the command for users, and adds the missing changelog entry.
Tests
No functional changes; existing unit and acceptance tests for
auth logoutcontinue to pass.