fix(browser): Apply Http timing attributes to streamed http.client spans#19643
Open
Lms24 wants to merge 7 commits intolms/feat-span-firstfrom
Open
fix(browser): Apply Http timing attributes to streamed http.client spans#19643Lms24 wants to merge 7 commits intolms/feat-span-firstfrom
http.client spans#19643Lms24 wants to merge 7 commits intolms/feat-span-firstfrom
Conversation
Lms24
changed the base branch from
lms/feat-span-first
to
lms/test-span-streaming-browser-integration-tests
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
force-pushed
the
lms/test-span-streaming-browser-integration-tests
branch
from
c28083a to
06bccc6
Compare
Base automatically changed from
lms/test-span-streaming-browser-integration-tests
to
lms/feat-span-first
March 6, 2026 12:33
Lms24
force-pushed
the
lms/fix-http-client-request-timing-attributes
branch
from
bfee1f9 to
6b0eb4f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a temporary bug in span streaming where we didn't add Http timing attributes (see #19613). We can fix this by following OTels approach:
http.clientspans until either 300ms pass by or we receive the PerformanceResourceTiming entry with the respective timing information. Of course we end the span with the original timestamp then.closes #19613