feat(effect): Add logging to Sentry.effectLayer#19656
Open
JPeer264 wants to merge 2 commits intojp/add-effect-sdkfrom
Open
feat(effect): Add logging to Sentry.effectLayer#19656JPeer264 wants to merge 2 commits intojp/add-effect-sdkfrom
JPeer264 wants to merge 2 commits intojp/add-effect-sdkfrom
Conversation
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/4
branch
from
4ac8fdb to
d12dae1
Compare
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/4
branch
from
d12dae1 to
751cac1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
approved these changes
Mar 6, 2026
andreiborza
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| expect(sentryCore.logger.info).toHaveBeenCalledWith('Processing: data'); | ||
| }).pipe(Effect.provide(loggerLayer)), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Feat PR missing integration or E2E test
Low Severity
This is a feat PR that adds Effect log forwarding to Sentry, but it only includes vitest unit tests. Per the project review rules, feat PRs are expected to include at least one integration or E2E test. The existing tests validate the logger and layer composition well at the unit level, but an integration or E2E test (e.g., in dev-packages/e2e-tests/ or dev-packages/node-integration-tests/) verifying that Effect logs actually arrive as Sentry log entries end-to-end would increase confidence.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the functionality to send logs to Sentry by setting
enableLogs: truein theSentry.effectLayer