feat(deps): Bump OpenTelemetry dependencies#19682
Open
andreiborza wants to merge 1 commit intodevelopfrom
Open
feat(deps): Bump OpenTelemetry dependencies#19682andreiborza wants to merge 1 commit intodevelopfrom
andreiborza wants to merge 1 commit intodevelopfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
- Bump @opentelemetry/context-async-hooks from 2.5.1 to 2.6.0 - Bump @opentelemetry/core from 2.5.1 to 2.6.0 - Bump @opentelemetry/instrumentation from 0.211.0 to 0.213.0 - Bump @opentelemetry/instrumentation-amqplib from 0.58.0 to 0.60.0 - Bump @opentelemetry/instrumentation-aws-sdk from 0.66.0 to 0.68.0 - Bump @opentelemetry/instrumentation-connect from 0.54.0 to 0.56.0 - Bump @opentelemetry/instrumentation-dataloader from 0.28.0 to 0.30.0 - Bump @opentelemetry/instrumentation-express from 0.59.0 to 0.61.0 - Bump @opentelemetry/instrumentation-fs from 0.30.0 to 0.32.0 - Bump @opentelemetry/instrumentation-generic-pool from 0.54.0 to 0.56.0 - Bump @opentelemetry/instrumentation-graphql from 0.58.0 to 0.61.0 - Bump @opentelemetry/instrumentation-hapi from 0.57.0 to 0.59.0 - Bump @opentelemetry/instrumentation-http from 0.211.0 to 0.213.0 - Bump @opentelemetry/instrumentation-ioredis from 0.59.0 to 0.61.0 - Bump @opentelemetry/instrumentation-kafkajs from 0.20.0 to 0.22.0 - Bump @opentelemetry/instrumentation-knex from 0.55.0 to 0.57.0 - Bump @opentelemetry/instrumentation-koa from 0.59.0 to 0.61.0 - Bump @opentelemetry/instrumentation-lru-memoizer from 0.55.0 to 0.57.0 - Bump @opentelemetry/instrumentation-mongodb from 0.64.0 to 0.66.0 - Bump @opentelemetry/instrumentation-mongoose from 0.57.0 to 0.59.0 - Bump @opentelemetry/instrumentation-mysql from 0.57.0 to 0.59.0 - Bump @opentelemetry/instrumentation-mysql2 from 0.57.0 to 0.59.0 - Bump @opentelemetry/instrumentation-nestjs-core from 0.57.0 to 0.59.0 - Bump @opentelemetry/instrumentation-pg from 0.63.0 to 0.65.0 - Bump @opentelemetry/instrumentation-redis from 0.59.0 to 0.61.0 - Bump @opentelemetry/instrumentation-tedious from 0.30.0 to 0.32.0 - Bump @opentelemetry/instrumentation-undici from 0.21.0 to 0.23.0 - Bump @opentelemetry/resources from 2.5.1 to 2.6.0 - Bump @opentelemetry/sdk-trace-base from 2.5.1 to 2.6.0 - Bump @opentelemetry/semantic-conventions from 1.39.0 to 1.40.0 - Bump @prisma/instrumentation from 7.2.0 to 7.4.2 - Bump @fastify/otel from 0.16.0 to 0.17.1 - Bump import-in-the-middle from ^2.0.6 to ^3.0.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/4-aMP6Zabhb5qeepADKpI3z4_QabyNnztuj6SDAbsmk
andreiborza
force-pushed
the
ab/bump-otel
branch
from
4755ff2 to
3f4d8da
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "@opentelemetry/resources": "^2.5.1", | ||
| "@opentelemetry/sdk-trace-base": "^2.5.1", | ||
| "@opentelemetry/semantic-conventions": "^1.39.0", | ||
| "@opentelemetry/context-async-hooks": "^2.6.0", |
There was a problem hiding this comment.
Bug: The code uses an outdated API for import-in-the-middle v3.0.0. createAddHookMessageChannel no longer returns addHookMessagePort, which will cause a runtime error and break ESM instrumentation.
Severity: CRITICAL
Suggested Fix
Update the code to use the new API returned by createAddHookMessageChannel in v3. Destructure registerOptions from the function call and pass it directly to moduleModule.register(). The call should look like: const { registerOptions } = createAddHookMessageChannel(); moduleModule.register('import-in-the-middle/hook.mjs', import.meta.url, registerOptions);.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/node-core/package.json#L108
Potential issue: The pull request upgrades the `import-in-the-middle` dependency to
version 3.0.0, a major version with breaking API changes. However, the code in
`esmLoader.ts` was not updated to reflect these changes. The function
`createAddHookMessageChannel` no longer returns `addHookMessagePort` in v3. Instead, it
returns `{ registerOptions, waitForAllMessagesAcknowledged }`. This mismatch will cause
`addHookMessagePort` to be `undefined`, leading to a runtime error when it's passed in
the `transferList` to `moduleModule.register()`. This failure will prevent ESM module
instrumentation from being registered, effectively breaking all OpenTelemetry
instrumentation for ESM modules.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
Nope, the 3.0 release only dropped node support.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Closes #19683 (added automatically)