fix(explore): Remove empty field params from Explore URL#110655
Open
nsdeschenes wants to merge 3 commits intomasterfrom
Open
fix(explore): Remove empty field params from Explore URL#110655nsdeschenes wants to merge 3 commits intomasterfrom
nsdeschenes wants to merge 3 commits intomasterfrom
Conversation
Filter out empty strings from decoded field arrays in getFieldsFromLocation so stale `field=` query params don't cause validation errors when saving queries.
Defense-in-depth: strip empty strings from fields before writing to the URL in both spans and logs query param helpers.
github-actions
bot
added
the
Scope: Frontend
nsdeschenes
changed the title
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Add explicit null check before optional chaining so that updateNullableLocation still receives null (meaning "delete the key") rather than undefined (meaning "do nothing") when fields is null.
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty
field=parameters in the Explore page URL (e.g.&field=timestamp&field=&field=parent_span) cause validation errors when saving a query, because the empty string is treated as a required-but-blank field name.This adds defense-in-depth filtering at both the read and write boundaries:
getFieldsFromLocationnow filters out empty strings afterdecodeList(), so any stalefield=in the URL is stripped before the app sees it.getTargetWithReadableQueryParamsfilter empty strings before writing fields back to the URL.Fixes EXP-838