C#: Delete CFG for static assignables.#21462
Closed
aschackmull wants to merge 1 commit intogithub:mainfrom
Closed
Conversation
aschackmull
force-pushed
the
csharp/no-static-assignable-cfg
branch
from
616c93f to
38d2bbb
Compare
Contributor
Author
|
Hmm, this is no good - data flow currently depends on cfg nodes. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializers for static assignables currently have "free-standing" CFG snippets instead of existing within a callable. Ideally we'd introduce a callable in the extractor to wrap them and their CFG, but let's first see if we can simply get rid of those small CFG snippets.
This is motivated by the shift to the shared CFG library where we need CFG scopes to be Callables.