Fix push_files schema missing AdditionalProperties for Visual Studio 2026#2168
Open
04cb wants to merge 1 commit intogithub:mainfrom
Open
Fix push_files schema missing AdditionalProperties for Visual Studio 2026#216804cb wants to merge 1 commit intogithub:mainfrom
04cb wants to merge 1 commit intogithub:mainfrom
Conversation
…2026 Visual Studio 2026 requires array item schemas to explicitly set additionalProperties to false. The push_files tool's files array was missing this, causing HTTP 400 errors when the tool was invoked. This adds AdditionalProperties: false to the files array items schema to indicate only path and content properties are allowed.
SamMorrowDrums
approved these changes
Mar 7, 2026
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Thank you, I had meant to address this weeks ago but it slipped past me.
SamMorrowDrums
approved these changes
Mar 7, 2026
Collaborator
|
@04cb you will need to update the toolsnaps before merge however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2011. Visual Studio 2026 requires array item schemas to explicitly set additionalProperties to false. The push_files tool's files array was missing this, causing HTTP 400 errors when the tool was invoked from VS 2026 Insiders.
This adds AdditionalProperties: false to the files array items schema to indicate only path and content properties are allowed.