Feat: integrate code review extension in PR workflow instead of using customized review prompt#471
Conversation
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Signed-off-by: cynthialong0-0 <82900738+cynthialong0-0@users.noreply.github.com>
|
@gemini-cli /review |
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
1 similar comment
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @cynthialong0-0, but I was unable to process your request. Please see the logs for more details. |
|
@gemini-cli /review |
|
🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
1 similar comment
|
🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
@gemini-cli /review |
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
@gemini-cli /review |
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This Pull Request successfully updates the PR review workflow to integrate the dedicated code-review extension instead of using customized local prompts. However, there are a few critical issues with the configuration of the GitHub MCP server in the workflow files that will cause deployment failures and need to be fixed before merging.
🔍 General Feedback
- Docker Environment Variables: The current modifications to how
GITHUB_PERSONAL_ACCESS_TOKENis passed viadocker run -ein.github/workflows/gemini-invoke.ymlintroduces a breakage. Variables inside theargsarray bypass shell evaluation and are therefore passed as literals rather than pulling the value from theenvblock. - Workflow Action References: Make sure any workflow file referencing a testing branch is reverted back to pointing at
@main. - Evals Stability: Relying on runtime HTTP requests to fetch files during evaluation testing can introduce non-deterministic failures. Whenever feasible, favor using mocked local fixtures over remote file downloads to keep evaluations isolated.
Overview
This PR integrates code review extension (https://github.com/gemini-cli-extensions/code-review) in the PR workflow.
fixes #468
Changes
Next step