Skip to content

Feat: integrate code review extension in PR workflow instead of using customized review prompt#471

Merged
cynthialong0-0 merged 16 commits intomainfrom
feat/code-review-integration
Mar 11, 2026
Merged

Feat: integrate code review extension in PR workflow instead of using customized review prompt#471
cynthialong0-0 merged 16 commits intomainfrom
feat/code-review-integration

Conversation

@cynthialong0-0
Copy link
Collaborator

@cynthialong0-0 cynthialong0-0 commented Mar 2, 2026

Overview

This PR integrates code review extension (https://github.com/gemini-cli-extensions/code-review) in the PR workflow.

fixes #468

Changes

  • Update gemini-review.yml to install code-review extension and prompt to point to code-review instructions
  • Update PR workflow readme
  • Update related eval tests

Next step

  • Cleanup e.g. SetupGithubCommands, generate_examples.sh, gemini-review prompts

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 2, 2026

🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@cynthialong0-0 cynthialong0-0 requested review from jerop and kschaab March 2, 2026 17:38
@cynthialong0-0 cynthialong0-0 marked this pull request as ready for review March 2, 2026 17:38
@cynthialong0-0 cynthialong0-0 requested review from a team as code owners March 2, 2026 17:38
@cynthialong0-0 cynthialong0-0 requested review from R2wenD2, mattKorwel and verbanicm and removed request for R2wenD2, mattKorwel and verbanicm March 2, 2026 17:38
@cynthialong0-0 cynthialong0-0 removed the request for review from kschaab March 2, 2026 19:01
@cynthialong0-0 cynthialong0-0 enabled auto-merge (squash) March 2, 2026 20:41
@cynthialong0-0 cynthialong0-0 disabled auto-merge March 2, 2026 22:20
@cynthialong0-0
Copy link
Collaborator Author

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

1 similar comment
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 I'm sorry @cynthialong0-0, but I was unable to process your request. Please see the logs for more details.

@cocosheng-g
Copy link
Collaborator

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

1 similar comment
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@cynthialong0-0
Copy link
Collaborator Author

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@cynthialong0-0
Copy link
Collaborator Author

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Contributor

@gemini-cli gemini-cli bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This Pull Request successfully updates the PR review workflow to integrate the dedicated code-review extension instead of using customized local prompts. However, there are a few critical issues with the configuration of the GitHub MCP server in the workflow files that will cause deployment failures and need to be fixed before merging.

🔍 General Feedback

  • Docker Environment Variables: The current modifications to how GITHUB_PERSONAL_ACCESS_TOKEN is passed via docker run -e in .github/workflows/gemini-invoke.yml introduces a breakage. Variables inside the args array bypass shell evaluation and are therefore passed as literals rather than pulling the value from the env block.
  • Workflow Action References: Make sure any workflow file referencing a testing branch is reverted back to pointing at @main.
  • Evals Stability: Relying on runtime HTTP requests to fetch files during evaluation testing can introduce non-deterministic failures. Whenever feasible, favor using mocked local fixtures over remote file downloads to keep evaluations isolated.

@cynthialong0-0 cynthialong0-0 merged commit d87bfa2 into main Mar 11, 2026
43 checks passed
@cynthialong0-0 cynthialong0-0 deleted the feat/code-review-integration branch March 11, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Integrate code review extension in PR workflow

3 participants