Open
Conversation
Remove stray items from BUILD file that aren't actually required.
Add build --linkopt in .bazeliskrc to fix warning about deprecated/buggy Rust linker.
willbeason
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously running
bazelisk test ...:alldid not run Rust tests. This change configures crate in MODULE.bazel.Add rust/BUILD with minimal library and test configuration. I've copied the private visibility rules that other language's BUILD files use, let me know if we don't want that.
I modified the CSVReader used in testing to:
I'm not super confident in how idiomatic this rust code is, main bit was to help me while debugging why bazelisk test wasn't working.