Make CabalFileText to wrap a strict ByteString, not a lazy one#1468
Merged
Make CabalFileText to wrap a strict ByteString, not a lazy one#1468
Conversation
Cabal files are definitely small enough to use a strict ByteString. This eliminates one possible source of issues with lazy IO.
Bodigrim
force-pushed
the
strict-CabalFileText
branch
from
75c6659 to
36f2763
Compare
Member
|
Thanks. I am not so knowledgeable about which String types are most efficient at different sizes and access patterns, but I think that you probably are, so I will trust your judgment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cabal files are definitely small enough to use a strict
ByteString. This eliminates one possible source of issues with lazy IO. Tackles half of #1451.