fix: use line-based heuristic for auto-export detection #46
Open
simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
Open
fix: use line-based heuristic for auto-export detection #46simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
…ev#39) The naive .contains("export") check in register_handler() would false-positive on string literals (e.g. '<config mode="export">'), comments (e.g. // TODO: export data), and identifiers (e.g. exportPath), skipping auto-export and causing handler registration to fail. Replace with has_export_statement() which checks whether any source line starts with 'export' (after leading whitespace), correctly ignoring occurrences inside strings, comments, and variable names. Closes hyperlight-dev#39 Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
bug
ludfjig
approved these changes
Mar 10, 2026
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
lgtm, it's not perfect but better than before for sure
| // not the word "export" inside string literals, comments, or identifiers. | ||
|
|
||
| #[test] | ||
| fn handler_with_export_in_string_literal() { |
Contributor
There was a problem hiding this comment.
Should these be unit tests instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naive .contains("export") check in register_handler() would false-positive on string literals (e.g. ''), comments (e.g. // TODO: export data), and identifiers (e.g. exportPath), skipping auto-export and causing handler registration to fail.
Replace with has_export_statement() which checks whether any source line starts with 'export' (after leading whitespace), correctly ignoring occurrences inside strings, comments, and variable names.
Closes #39