Add wasm-runtime as a dependency and find it using cargo-metadata#410
Merged
jprendes merged 5 commits intohyperlight-dev:mainfrom Mar 9, 2026
Merged
Add wasm-runtime as a dependency and find it using cargo-metadata#410jprendes merged 5 commits intohyperlight-dev:mainfrom
jprendes merged 5 commits intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
dblnz
reviewed
Mar 9, 2026
dblnz
approved these changes
Mar 9, 2026
Contributor
dblnz
left a comment
There was a problem hiding this comment.
LGTM!
Beside the other benefits, this change makes debugging static languages a lot simpler by having a predictable path for wasm_runtime binary that needs to be provided to GDB/LLDB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds wasm-runtime as a dependency of hyperlight-wasm.
Then, for building it in the hyperlight-wasm buildscript, find its location using cargo metadata.
This PR has 2 main parts>
Out of scope:
These are out of scope as currently the macros have baked in assumptions aobut hyperlight.
Remaining work (for other PRs)