Skip to content

Migrated ZimHostFragment -> ZimHostRoute#4736

Open
atharvyadav22 wants to merge 1 commit intokiwix:mainfrom
atharvyadav22:migrate/zim
Open

Migrated ZimHostFragment -> ZimHostRoute#4736
atharvyadav22 wants to merge 1 commit intokiwix:mainfrom
atharvyadav22:migrate/zim

Conversation

@atharvyadav22
Copy link
Contributor

Fixes: #4615

@atharvyadav22
Copy link
Contributor Author

@MohitMaliFtechiz
Sorry for the delay and not able to contribute in other Prs i was prioritizing this migration it was difficult because of many classes which required understanding.
This is an initial commit ill later add test cases too for now please review the logic.

I have added comments to help other read the code, also from previous migration i have implemented your points so it saves time.

Migration covered these parts-

  • Hotspot now use composable lifecycle
  • Merged Di and common fragment files and updated in ViewModel itself
  • Handled Playstore and custom apps logic
  • Permission block kept the same
  • Instead of suppressing i made small code blocks.
  • for the checkbox i modified the logic cause it wasn't updating its state with toggleSelection.

@atharvyadav22
Copy link
Contributor Author

@MohitMaliFtechiz Done with this migration waiting for your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ZimHostFragment from project, and use pure composable instead.

1 participant