Skip to content

remove deprecated TLS package#3333

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:remove-tls-package
Mar 14, 2026
Merged

remove deprecated TLS package#3333
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:remove-tls-package

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Mar 12, 2026

This isn't a breaking change since we've never published this package in a release

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo March 12, 2026 16:47
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2026
@dprotaso
Copy link
Member Author

/assign @Fedosin @twoGiants @linkvt

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.87%. Comparing base (5504026) to head (7ea382b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
+ Coverage   74.84%   74.87%   +0.03%     
==========================================
  Files         189      189              
  Lines        8287     8287              
==========================================
+ Hits         6202     6205       +3     
+ Misses       1844     1841       -3     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fedosin
Copy link
Contributor

Fedosin commented Mar 13, 2026

/retest

@dprotaso
Copy link
Member Author

Downstream errors are a given until we move to the new package location

  go: knative.dev/operator/hack imports
  	knative.dev/eventing/cmd/heartbeats imports
  	knative.dev/eventing/pkg/eventingtls imports
  	knative.dev/pkg/tls: no required module provides package knative.dev/pkg/tls; to add it:
  	go get knative.dev/pkg/tls

@Fedosin
Copy link
Contributor

Fedosin commented Mar 13, 2026

/retest

@dprotaso
Copy link
Member Author

I kicked of the knobots dep bumps.

@dprotaso
Copy link
Member Author

Note: downstream tests are not blocking - it's more informative.

The PR just needs an/lgtm

Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2026
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0b827f4 into knative:main Mar 14, 2026
54 of 86 checks passed
@dprotaso dprotaso deleted the remove-tls-package branch March 14, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants