Merged
Conversation
HedgehogCode
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
HedgehogCode
force-pushed
the
todo/AP-25748-ci-pipeline-blocking
branch
from
9f03edd to
f322f0b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository’s GitHub Actions CI by splitting the former combined workflow into dedicated Python and JavaScript workflows that only run when relevant files change, while also updating JS lockfile dependencies.
Changes:
- Replace the monolithic
.github/workflows/ci.ymlwith separatepython-ci.ymlandjs-ci.ymlworkflows. - Gate the workflows via
pathsfilters so they only run when Python/JS-related files change. - Update
org.knime.python3.scripting.nodes/js-src/package-lock.jsonwith dependency version bumps (including rollup/minimatch/ajv/dom-purify/svgo-related entries).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
org.knime.python3.scripting.nodes/js-src/package-lock.json |
Updates pinned/transitive JS dependencies. |
.github/workflows/python-ci.yml |
New Python formatting workflow with path-based triggering. |
.github/workflows/js-ci.yml |
New multi-job JS workflow (install/typecheck/lint/tests/audit/build) with path-based triggering. |
.github/workflows/ci.yml |
Removes the prior combined CI workflow. |
Files not reviewed (1)
- org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
HedgehogCode
force-pushed
the
todo/AP-25748-ci-pipeline-blocking
branch
from
f322f0b to
47b826b
Compare
marc-lehner
requested changes
Mar 13, 2026
HedgehogCode
force-pushed
the
todo/AP-25748-ci-pipeline-blocking
branch
from
55143d3 to
e60d662
Compare
- Split it into multiple jobs (if one fails it does not block the others) - Only run it if the frontend code changed - Move Python format check into separate workflow and run it only if Python code changed AP-25748 (Do not block merges if npm audit fails for scripting editors)
AP-25748 (Do not block merges if npm audit fails for scripting editors)
HedgehogCode
force-pushed
the
todo/AP-25748-ci-pipeline-blocking
branch
from
e60d662 to
2c1979f
Compare
|
marc-lehner
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-25748 (Do not block merges if npm audit fails for scripting editors)