Logic for method overload with different types#172
Open
CatarinaGamboa wants to merge 3 commits intomainfrom
Open
Logic for method overload with different types#172CatarinaGamboa wants to merge 3 commits intomainfrom
CatarinaGamboa wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
@copilot review it |
|
@CatarinaGamboa I've opened a new pull request, #173, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Fixes overload resolution for refinement/state transitions by selecting the correct refined function based on parameter types (not just arity), addressing issue #134 in the verifier’s method/constructor invocation checking.
Changes:
- Add
Context.getFunction(name, target, paramTypes)and type-based argument matching for refined function lookup. - Thread resolved parameter types through
MethodsFunctionsCheckerinvocation/constructor checking with a safe fallback to arity-based lookup. - Add new example test suites covering overloaded constructors (correct and error cases).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| liquidjava-verifier/src/main/java/liquidjava/processor/refinement_checker/general_checkers/MethodsFunctionsChecker.java | Passes resolved parameter types through invocation/constructor refinement selection; adds helper overload for refinement function lookup. |
| liquidjava-verifier/src/main/java/liquidjava/processor/context/Context.java | Adds type-based refined function lookup via parameter type matching. |
| liquidjava-example/src/main/java/testSuite/classes/overload_constructors_error/ThrowableRefinements.java | Adds external refinements for Throwable to reproduce the overloaded-constructor state transition bug. |
| liquidjava-example/src/main/java/testSuite/classes/overload_constructors_error/Test.java | Adds failing example where the Throwable(Throwable) constructor should prevent initCause. |
| liquidjava-example/src/main/java/testSuite/classes/overload_constructors_error/.expected | Declares expected failure title for the error suite. |
| liquidjava-example/src/main/java/testSuite/classes/overload_constructors_correct/ThrowableRefinements.java | Same refinements used for the passing variant of the scenario. |
| liquidjava-example/src/main/java/testSuite/classes/overload_constructors_correct/Test.java | Adds passing example where initCause is not invoked after Throwable(Throwable). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xample/src/main/java/testSuite/classes/overload_constructors_error/ThrowableRefinements.java
Outdated
Show resolved
Hide resolved
liquidjava-example/src/main/java/testSuite/classes/overload_constructors_error/Test.java
Outdated
Show resolved
Hide resolved
…nstructors_error/ThrowableRefinements.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nstructors_error/Test.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rcosta358
reviewed
Mar 10, 2026
| && argumentTypesMatch(fi.getArguments(), paramTypes)) | ||
| return fi; | ||
| } | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Instead of adding a fallback everywhere this method is called, where if the lookup by exact parameter types returns null we try to get the function by the number of parameters, we could just call it here:
Suggested change
| return null; | |
| return getFunction(name, target, paramTypes.size()); |
I tested it locally and it worked fine.
Comment on lines
+67
to
+69
| if (f == null) | ||
| f = rtc.getContext().getFunction(exe.getSimpleName(), exe.getDeclaringType().getQualifiedName(), | ||
| ctConstructorCall.getArguments().size()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(exe.getSimpleName(), exe.getDeclaringType().getQualifiedName(), | |
| ctConstructorCall.getArguments().size()); |
Comment on lines
+230
to
+231
| if (f == null) | ||
| f = rtc.getContext().getFunction(method.getSimpleName(), ctype, invocation.getArguments().size()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(method.getSimpleName(), ctype, invocation.getArguments().size()); |
Comment on lines
+249
to
+252
| if (f == null) | ||
| f = rtc.getContext().getFunction(String.format("%s.%s", className, methodName), className, paramTypes); | ||
| if (f == null) | ||
| f = getRefinementFunction(methodName, className, paramTypes.size()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(String.format("%s.%s", className, methodName), className, paramTypes); | |
| if (f == null) | |
| f = getRefinementFunction(methodName, className, paramTypes.size()); |
Comment on lines
+272
to
+273
| if (f == null) | ||
| f = rtc.getContext().getFunction(qualifiedSignature, ctype, argSize); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(qualifiedSignature, ctype, argSize); |
Comment on lines
+282
to
+283
| if (f == null) | ||
| f = rtc.getContext().getFunction(signature, ctype, argSize); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(signature, ctype, argSize); |
Comment on lines
+290
to
+291
| if (f == null) | ||
| f = rtc.getContext().getFunction(name, ctype, argSize); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(name, ctype, argSize); |
Comment on lines
+300
to
+301
| if (f == null) | ||
| f = rtc.getContext().getFunction(completeName, ctype, argSize); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(completeName, ctype, argSize); |
Comment on lines
+321
to
+322
| if (f == null) | ||
| f = rtc.getContext().getFunction(methodName, className, arguments.size()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (f == null) | |
| f = rtc.getContext().getFunction(methodName, className, arguments.size()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #134 .
We now account for the types of arguments when identifying the function that is called.
The main change is
checkInvocationRefinementsnow has another parameter for the param types, and we change all its calls to capture the arguments' types and call the correct function.