Skip to content

fix: Use localstack/localstack-pro by default#111

Merged
aidehn merged 4 commits intomasterfrom
aidehn/feat/use-pro-image
Mar 6, 2026
Merged

fix: Use localstack/localstack-pro by default#111
aidehn merged 4 commits intomasterfrom
aidehn/feat/use-pro-image

Conversation

@aidehn
Copy link
Contributor

@aidehn aidehn commented Mar 5, 2026

Changes

  • Updates the code to no longer use localstack/localstack and opt to use localstack/localstack-pro instead. The prior can still be used if specified.
  • The workflow doesn't work on latest due to an issue with the Docker SDK which makes me believe it has been broken for quite a while since our testing workflow usually tests against Pro by default.
    • Since it's not been raised it is likely an issue specific to our test set up.

@aidehn aidehn changed the title fix: Migrate away from localstack/localstack fix: Use localstack/localstack-pro by default Mar 6, 2026
@aidehn aidehn force-pushed the aidehn/feat/use-pro-image branch from ab7375c to aba563e Compare March 6, 2026 11:43
@aidehn aidehn requested review from alexrashed, k-a-il and whummer March 6, 2026 11:50
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for jumping on this! I really am a bit puzzled by the failing pipeline, but I agree that the pipeline is just broken (which isn't surprising given that this project hasn't seen much traction / maintenance lately).

README.md Outdated

## Change Log

* v0.2.24: Make localstack/localstack-pro the default image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I guess this change will potentially break the usage of the library for some consumers (i.e. those who currently use it without an auth token). Maybe this change would be worth doing a minor bump and also reference the blog post for the image consolidation here? WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense! I'll make this a minor version bump and add some reference to the blog post 👍🏼

run: |
set -e
nohup docker pull localstack/localstack-ext > /dev/null &
nohup docker pull localstack/localstack-pro > /dev/null &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Given that this command can never have worked, I would actually opt to just remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@aidehn aidehn merged commit e3c299d into master Mar 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants