Fix infinite loop in Parser.with_names for malformed WITH statements#605
Merged
Fix infinite loop in Parser.with_names for malformed WITH statements#605
Parser.with_names for malformed WITH statements#605Conversation
Resolves #556. The parser would hang indefinitely when encountering malformed SQL with consecutive AS keywords in WITH clauses (e.g., "WITH a AS (...) AS g"). The issue was in the with_names property loop: after processing a WITH clause, if the next token was another AS keyword (invalid syntax), the parser would not advance the token, causing an infinite loop. This fix: - Detects malformed SQL with consecutive AS keywords after WITH queries - Raises ValueError("This query is wrong") instead of hanging - Ensures the token always advances to prevent infinite loops - Adds test case to verify the fix Co-Authored-By: Claude <noreply@anthropic.com>
macbre
changed the title
Parser.with_names for malformed WITH statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #556.
The parser would hang indefinitely when encountering malformed SQL with consecutive AS keywords in WITH clauses (e.g., "WITH a AS (...) AS g").
The issue was in the with_names property loop: after processing a WITH clause, if the next token was another AS keyword (invalid syntax), the parser would not advance the token, causing an infinite loop.
This fix: