Clarify handling of empty arguments in xpath function contains#10814
Clarify handling of empty arguments in xpath function contains#10814MarkvanMents merged 5 commits intomendix:developmentfrom
Conversation
|
Needs team review |
pijuskri
force-pushed
the
dat/contains-empty
branch
from
aac06dd to
ce9d797
Compare
.../docs/refguide/modeling/xpath/xpath-constraints/xpath-constraint-functions/xpath-contains.md
Outdated
Show resolved
Hide resolved
.../docs/refguide/modeling/xpath/xpath-constraints/xpath-constraint-functions/xpath-contains.md
Outdated
Show resolved
Hide resolved
|
The same things hold for |
.../docs/refguide/modeling/xpath/xpath-constraints/xpath-constraint-functions/xpath-contains.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### attribute | ||
|
|
||
| `attribute` specifies the attribute to test in. Attribute must be of the **String** type. |
There was a problem hiding this comment.
It doesn't have to be a simple attribute, it can also be a long path ending at an attribute.
There was a problem hiding this comment.
I thought about mentioning that, but the entire xpath constraint documentation never explicitly mentions paths and always refers to attributes. I don't know if this distinction is necessary to highlight.
There was a problem hiding this comment.
@pijuskri
So you are saying that I can specify an attribute by either
[Sales.Customer_Address/Sales.Address[contains(City, 'otterda')]]
or
[Sales.Customer_Address[contains(Sales.Address/City, 'otterda')]]
?
In that case, I think we should add a general point about what we mean by attribute in https://docs.mendix.com/refguide/xpath-constraint-functions/
There was a problem hiding this comment.
That is how i understood it. It would be ideal to clarify this like you mention.,
There was a problem hiding this comment.
Sorry for the delayed review, the path indeed should be different, added a comment on the correction
…ts-with and ends-with
pijuskri
force-pushed
the
dat/contains-empty
branch
from
ce9d797 to
1ac875d
Compare
|
Approved by datastorage team. |
content/en/docs/refguide/modeling/xpath/xpath-constraints/xpath-constraint-functions/_index.md
Outdated
Show resolved
Hide resolved
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
@pijuskri
Thanks for the correction. Looks good to me. Are you happy with my updates? If so, I'll merge.
|
@MarkvanMents LGTM, we can merge |
3 participants
No description provided.