feat: A naive replacement of both lodash methods.#156
Open
miccheng wants to merge 2 commits intomithunsatheesh:mainfrom
Open
feat: A naive replacement of both lodash methods.#156miccheng wants to merge 2 commits intomithunsatheesh:mainfrom
miccheng wants to merge 2 commits intomithunsatheesh:mainfrom
Conversation
- Change moduleResolution to node. - Fix RollUp issue by excluding the problematic module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A naive implementation of removing the 2
lodashfunctions.Initially tried to use the ES-Toolkit to replace the functions but ran into TSConfig issues. First i needed to change the
moduleResolutiontonode, which caused issues with RollUp's commonjs plugin:Anyway, just tot I would create a PR just to get some inputs.
Update:
I tried using ES-Toolkit again and just exclude that module from the CommonJS RolUp plugin (solution is based on this StackOverflow post.
Exclude the problematic file/package from the CommonJS plugin: