Skip to content

feat(assistant): handle process text#16622

Merged
alperozturk96 merged 7 commits intomasterfrom
feat/handle-process-text-in-assistant
Mar 9, 2026
Merged

feat(assistant): handle process text#16622
alperozturk96 merged 7 commits intomasterfrom
feat/handle-process-text-in-assistant

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 3, 2026

Screenshot_20260303_120311 Screenshot_20260303_120318
Screen.Recording.2026-03-03.at.12.08.56.mp4

<string name="assistant_screen_delete_task_alert_dialog_description">Are you sure you want to delete this task?</string>
<string name="assistant_screen_task_more_actions_bottom_sheet_delete_action">Delete Task</string>
<string name="assistant_screen_select_task_type_title">How can I help?</string>
<string name="assistant_screen_select_task_type_label">Choose an option</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kra-mo texts are updated feel free to make suggestion

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 6, 2026
@alperozturk96 alperozturk96 force-pushed the feat/handle-process-text-in-assistant branch from 90b50da to 2435c7a Compare March 9, 2026 07:21
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I find it weird that in the worse case, the user now has to tap on 3 things before they can actually do what they want. I'd prefer if this was just a scrolling list of buttons instead of a dropdown and an additional button. That way, you could ensure that the user just has to tap on one thing.

alperozturk96 and others added 5 commits March 9, 2026 14:02
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 alperozturk96 force-pushed the feat/handle-process-text-in-assistant branch from 2435c7a to dbbb6b7 Compare March 9, 2026 13:02
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Copy link
Collaborator Author

@kra-mo Please make suggestion for the texts if you have any other ideas :)

Screen_recording_20260309_141207.webm

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4141
Correctness7575
Dodgy code241241
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4343
Security1818
Total462462

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 merged commit 9be06c1 into master Mar 9, 2026
12 of 18 checks passed
@alperozturk96 alperozturk96 deleted the feat/handle-process-text-in-assistant branch March 9, 2026 15:42
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16622.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to directly share selected text to Assistant

3 participants