fix(files_sharing): respect config to skip certificate verification#58724
Open
salmart-dev wants to merge 1 commit intomasterfrom
Open
fix(files_sharing): respect config to skip certificate verification#58724salmart-dev wants to merge 1 commit intomasterfrom
salmart-dev wants to merge 1 commit intomasterfrom
Conversation
This is important especially for local development, as certificate are self-signed. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
requested review from
Altahrim,
artonge,
leftybournes and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Mar 4, 2026
salmart-dev
added
3. to review
Contributor
Author
|
Needs test updates 🫠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important especially for local development, as certificate are self-signed.
Summary
Federated sharing is broken locally and on instances using
sharing.federation.allowSelfSignedCertificatesand connecting to instances with a self-signed SSL certificate. Since we have a config setting for this, let's use it 👍Checklist
3. to review, feature component)stable32)AI (if applicable)