doc: test and test-only targets do not run linter anymore#62120
Open
Xstoudi wants to merge 2 commits intonodejs:mainfrom
Open
doc: test and test-only targets do not run linter anymore#62120Xstoudi wants to merge 2 commits intonodejs:mainfrom
Xstoudi wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62120 +/- ##
==========================================
+ Coverage 88.53% 89.66% +1.12%
==========================================
Files 703 676 -27
Lines 208598 206348 -2250
Branches 40227 39525 -702
==========================================
+ Hits 184674 185013 +339
+ Misses 15951 13468 -2483
+ Partials 7973 7867 -106 🚀 New features to boost your workflow:
|
Xstoudi
force-pushed
the
doc/test-do-not-lint
branch
from
53b3e54 to
cfe8f21
Compare
`make test` and `make test-only` targets no longer runs linters. This commit updates the inline comments and building doc to reflect reality. Fixes: nodejs#58606
Xstoudi
force-pushed
the
doc/test-do-not-lint
branch
from
cfe8f21 to
4cb68d2
Compare
targos
approved these changes
Mar 6, 2026
richardlau
approved these changes
Mar 6, 2026
lpinca
approved these changes
Mar 6, 2026
Renegade334
approved these changes
Mar 8, 2026
Renegade334
added
author ready
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62120 ✔ Done loading data for nodejs/node/pull/62120 ----------------------------------- PR info ------------------------------------ Title doc: test and test-only targets do not run linter anymore (#62120) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Xstoudi:doc/test-do-not-lint -> nodejs:main Labels doc, build, author ready, needs-ci, commit-queue-squash Commits 2 - doc: test and test-only targets do not run linter - format Committers 1 - Xavier Stouder <xavier@stouder.io> PR-URL: https://github.com/nodejs/node/pull/62120 Fixes: https://github.com/nodejs/node/issues/58606 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62120 Fixes: https://github.com/nodejs/node/issues/58606 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 05 Mar 2026 20:05:31 GMT ✔ Approvals: 5 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/62120#pullrequestreview-3902359217 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/62120#pullrequestreview-3903649372 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62120#pullrequestreview-3905667451 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/62120#pullrequestreview-3912118341 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62120#pullrequestreview-3913335876 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/22842950088 |
RafaelGSS
approved these changes
Mar 9, 2026
github-actions
bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testandmake test-onlytargets no longer runs linters. This commit updates the inline comments and building doc to reflect reality.Fixes: #58606