Conversation
|
Review requested:
|
|
@anonrig looks like there was a breaking change |
|
I will take a look |
|
cc @codebytere Shelley it seems unofficial.gn file will be deleted once this pull-request lands. We need to update update-merve.py file to avoid this. Just FYI in case you've some time (and faster than me) to fix it! |
3c78a76 to
35dc3c1
Compare
|
PS: I've force pushed to remove the deleted files. |
|
The shared builds are failing because Node.js code is no longer compatible with Merve 1.0.0. Can we add some flag on merve that we could use to detect which syntax to use? E.g. #ifdef MERVE_USE_DOT_NAME
#define DOT_NAME(exp) (exp.name)
#else
#define DOT_NAME(exp) (exp)
#endif
exports_set->Add(context, CreateString(isolate, DOT_NAME(exp))).ToLocalChecked(); |
35dc3c1 to
fbd4685
Compare
|
EDIT: that being said, it looks like the non-shared build is still failing. Switched to a function template, which is a more elegant solution anyway |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62149 +/- ##
=======================================
Coverage 89.65% 89.66%
=======================================
Files 676 676
Lines 206543 206541 -2
Branches 39547 39542 -5
=======================================
+ Hits 185184 185191 +7
- Misses 13480 13496 +16
+ Partials 7879 7854 -25
🚀 New features to boost your workflow:
|
This is an automated update of merve to 1.2.0.