fix(api): resolve issue causing the example API to fail in monorepos#225
Open
wise-king-sullyman wants to merge 1 commit intomainfrom
Open
fix(api): resolve issue causing the example API to fail in monorepos#225wise-king-sullyman wants to merge 1 commit intomainfrom
wise-king-sullyman wants to merge 1 commit intomainfrom
Conversation
Contributor
WalkthroughThis PR adds monorepo support to the examples API endpoint by introducing base path resolution for content entries. The implementation tracks package-specific base paths from content entries and uses them as fallback locations when resolving example file paths, enabling the API to work correctly in monorepo configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213
Assisted by Claude Code
I've got a local test of this pulled into org deployed at https://9ca89a13.patternfly-org.pages.dev/api
You can access examples via the examples api on it proving that this fix should work once it's pulled in downstream, such as https://9ca89a13.patternfly-org.pages.dev/api/v6/components/alert/react/examples/AlertGroupAsync
Summary by CodeRabbit
Tests
Bug Fixes