Merged
Conversation
Ehyiah
force-pushed
the
trad-fr-hot-reload
branch
from
1410da5 to
588f952
Compare
henderkes
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds French documentation for FrankenPHP’s Hot Reload feature, aligning the docs/fr set with the existing English docs/hot-reload.md content.
Changes:
- Added a full French translation of the Hot Reload documentation page (
docs/fr/hot-reload.md). - Included configuration examples and client-side integration details (Mercure + idiomorph / frankenphp-hot-reload) in French.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexandre-daubois
requested changes
Feb 25, 2026
docs/fr/hot-reload.md
Outdated
| Bien que le serveur détecte les modifications, le navigateur doit s'abonner à ces événements pour mettre à jour la page. | ||
| FrankenPHP expose l'URL du Hub Mercure à utiliser pour s'abonner aux modifications de fichiers via la variable d'environnement `$_SERVER['FRANKENPHP_HOT_RELOAD']`. | ||
|
|
||
| Une bibliothèque JavaScript pratique, [frankenphp-hot-reload](https://www.npmjs.com/package/frankenphp-hot-reload), est également disponible pour gérer la logique côté client. |
Member
There was a problem hiding this comment.
"Une bibliothèque JavaScript pratique" feels weird, like an automatic translation. I would remove "pratique" to sound more natural.
docs/fr/hot-reload.md
Outdated
| FrankenPHP expose l'URL du Hub Mercure à utiliser pour s'abonner aux modifications de fichiers via la variable d'environnement `$_SERVER['FRANKENPHP_HOT_RELOAD']`. | ||
|
|
||
| Une bibliothèque JavaScript pratique, [frankenphp-hot-reload](https://www.npmjs.com/package/frankenphp-hot-reload), est également disponible pour gérer la logique côté client. | ||
| Pour l'utiliser, ajoutez ce qui suit à votre layout principal : |
Member
There was a problem hiding this comment.
Same with "ce qui suit". We would better say "le code suivant" or something like that
docs/fr/hot-reload.md
Outdated
| Si vous exécutez votre application en [mode Worker](worker.md), le script de votre application reste en mémoire. | ||
| Cela signifie que les modifications de votre code PHP ne seront pas reflétées immédiatement, même si le navigateur se recharge. | ||
|
|
||
| Pour la meilleure expérience développeur, vous devriez combiner `hot_reload` avec [la sous-directive `watch` dans la directive `worker`](config.md#surveillance-des-modifications-de-fichier). |
Member
There was a problem hiding this comment.
We don't use "vous devriez", but "il est possible de combiner" for example, which sounds less robotic as well
docs/fr/hot-reload.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### Comment ça fonctionne |
Member
There was a problem hiding this comment.
Here, it sounds a bit to oral, doesn't it? I would go for "Fonctionnement interne" or similar
docs/fr/hot-reload.md
Outdated
|
|
||
| FrankenPHP inclut une fonctionnalité de **hot reload** intégrée, conçue pour améliorer considérablement l'expérience développeur. | ||
|
|
||
|  |
Member
There was a problem hiding this comment.
Why do we use Mercure here?
dunglas
force-pushed
the
trad-fr-hot-reload
branch
from
9fa4bc3 to
601d07a
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
Updated text for clarity and improved security warnings regarding hot reload feature. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
dunglas
force-pushed
the
trad-fr-hot-reload
branch
from
601d07a to
849ce61
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, there doesn't seem to be an open MR for translating the new hot reload feature. Here's what I can offer.