Open
Conversation
| @@ -1,6 +1,5 @@ | |||
| package phpheaders | |||
|
|
|||
| import "C" | |||
Contributor
There was a problem hiding this comment.
Not having import "C" in modules makes test ./... fail sometimes.
It's a weird bug with cgo gcc linking.
alexandre-daubois
force-pushed
the
chore/remove-useless-cgo-imports
branch
from
1e10aca to
032c373
Compare
Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unnecessary cgo triggers/imports and an unused C header include, reducing build overhead (especially avoiding needless cgo requirements in otherwise pure-Go internal packages).
Changes:
- Removed unused
import "C"(and cgo preamble) fromworker.go. - Removed unused
import "C"frominternal/stateandinternal/phpheadersto keep them pure-Go. - Dropped the unused
<unistd.h>include fromfrankenphp.c.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| worker.go | Removes redundant cgo preamble/import that wasn’t referenced. |
| internal/state/state.go | Removes cgo import so the package no longer unnecessarily requires cgo. |
| internal/phpheaders/phpheaders.go | Removes cgo import so the package remains pure-Go. |
| frankenphp.c | Removes an unused POSIX header include (unistd.h). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.