Fix GH-21357: XSLTProcessor works with DOMDocument, but fails with Dom\XMLDocument#21371
Open
ndossche wants to merge 3 commits intophp:PHP-8.4from
Open
Fix GH-21357: XSLTProcessor works with DOMDocument, but fails with Dom\XMLDocument#21371ndossche wants to merge 3 commits intophp:PHP-8.4from
ndossche wants to merge 3 commits intophp:PHP-8.4from
Conversation
… Dom\XMLDocument Registering namespace after the parsing is too late because parsing can fail due to attributes referencing namespaces. So we have to register fake namespaces before the parsing. However, the clone operation reconciles namespaces in the wrong way, so we have to clone via an object.
devnexen
reviewed
Mar 7, 2026
devnexen
approved these changes
Mar 7, 2026
Girgias
approved these changes
Mar 7, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
The new logic seems sensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering namespace after the parsing is too late because parsing can fail due to attributes referencing namespaces.
So we have to register fake namespaces before the parsing. However, the clone operation reconciles namespaces in the wrong way, so we have to clone via an object.