Open
Conversation
dkliban
force-pushed
the
7315
branch
4 times, most recently
from
c313a9a to
b99e67c
Compare
mdellweg
reviewed
Feb 19, 2026
pulpcore/app/entrypoint.py
Outdated
| self.heartbeat() | ||
|
|
||
| def _heartbeat_loop(self): | ||
| while self.alive: |
Member
Author
There was a problem hiding this comment.
A gunicorn SyncWorker sets self.alive to False during graceful shutdown. This ensures that when a graceful shutdown is requested, the thread does not make another heartbeat update. This check is not critical, because the thread will be shut down soon anyway.
dkliban
force-pushed
the
7315
branch
2 times, most recently
from
ab07720 to
b35e2f0
Compare
mdellweg
requested changes
Mar 6, 2026
Member
mdellweg
left a comment
mdellweg
left a comment
There was a problem hiding this comment.
Please consider removing all the comments you successfully replaced by actual python code.
Assisted By: Claude Code fixes: pulp#7315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted By: Claude Code
fixes: #7315
📜 Checklist
See: Pull Request Walkthrough