Migrate ISODateTime converter from bot repository#311
Merged
jb3 merged 9 commits intopython-discord:mainfrom Mar 5, 2026
Merged
Migrate ISODateTime converter from bot repository#311jb3 merged 9 commits intopython-discord:mainfrom
ISODateTime converter from bot repository#311jb3 merged 9 commits intopython-discord:mainfrom
Conversation
Extracts the ISODateTime converter from the main bot repository. This allows other projects in the ecosystem to natively parse and validate ISO-8601 strings using discord.py's converter system.
❌ Deploy Preview for bot-core failed. Why did it fail? →
|
jb3
approved these changes
Mar 4, 2026
Member
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
Awesome!
Just the linting items that got picked up (unused ctx argument & import block sorting) & this looks good.
One minor nitpick, I think I prefer it being converters.py rather than converter.py.
Otherwise, great stuff!
jb3
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
ISODateTimeconverter is localized to the mainpython-discord/botrepository. During the development of the.gh statsfeature insir-lancebot(python-discord/sir-lancebot#1729), it was requested that this converter be migrated tobot-coreso it can be utilized across the wider ecosystem.Summary of Changes
ISODateTimeconverter class frombot/exts/utilities/converters.pydateutil.parser,datetime,discord.ext.commands) intopydis_core/utils/converters.py.This will allow
sir-lancebotand future bots to offload manual date validation directly to thediscord.pyframework.