Fix (#20975) subtyping and join for constrained TypeVars#20980
Open
Shrey-N wants to merge 4 commits intopython:masterfrom
Open
Fix (#20975) subtyping and join for constrained TypeVars#20980Shrey-N wants to merge 4 commits intopython:masterfrom
Shrey-N wants to merge 4 commits intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #20975 by refining subtyping and join logic for constrained
TypeVars.Previously, compatible types were flagged as incompatible because it failed to recognize a concrete type as a valid
subtypeeven when it matched every constraint.Changes:-
Subtyping: Updated
subtypes.pyto recognize concrete types as valid subtypes when they satisfy all TypeVar constraints.Join Logic: Modified
join.pyto ensure the TypeVar is preserved during join operations.This resolves incorrect
arg-typeerrors where compatible types were being flagged as incompatible in generic contexts.Closes #20975