[CMake][tmva] Fix SOFIE tests exclusion with builtin GSL#21582
Open
AdityaDRathore wants to merge 1 commit intoroot-project:masterfrom
Open
[CMake][tmva] Fix SOFIE tests exclusion with builtin GSL#21582AdityaDRathore wants to merge 1 commit intoroot-project:masterfrom
AdityaDRathore wants to merge 1 commit intoroot-project:masterfrom
Conversation
a3fe28b to
a088275
Compare
Test Results 21 files 21 suites 3d 1h 15m 9s ⏱️ Results for commit a088275. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
The TMVA-SOFIE test configurations in
tmva/sofie/test/CMakeLists.txtcurrently gate the GTest targets strictly onif(BLAS_FOUND).However, when ROOT is configured to fall back to the builtin GSL library to fulfill its BLAS interface requirement (
-Dbuiltin_gsl=ON), theuse_gsl_cblasCMake flag is correctly set toON, butBLAS_FOUNDremainsOFF.Consequently, TMVA successfully links against the internal
ROOT::BLASinterface, but the SOFIE execution tests (e.g.,TestRModelParserKeras,TestRModelParserPyTorch) are silently excluded from the build manifest.This patch updates the capability checks to account for both standalone BLAS discovery and GSL CBLAS fallback by verifying
if (BLAS_FOUND OR use_gsl_cblas).Reproducer
cmake -Dbuiltin_gsl=ON -Dtpython=ON -DROOT_TEST_KERAS=ON ../src cmake --build . --target TestRModelParserKeras(Fails: Target does not exist prior to this patch).
Changes or fixes:
The capability checks in
tmva/sofie/test/CMakeLists.txtneed to account for both standalone BLAS discovery and GSL CBLAS fallback.For instance, surrounding the GTest targets, the conditional logic:
if (BLAS_FOUND)And
Should be updated to:
And
(I have tested this patch locally and it successfully re-enables the test suite compilation while correctly linking TestRModelParserKeras against the GSL CBLAS interface).
Checklist:
@bellenot @lmoneta @sanjibansg @guitargeek