Added setPitch, proper indenting#50
Added setPitch, proper indenting#50vincurekf wants to merge 1 commit intorserota:masterfrom vincurekf:master
Conversation
I've just added Wad.prototype.setPitch() (as it was not possible to set pitch to single wad on playback, and tryed to correct indeting in code and unify it a bit to be easily readable.
|
I'm not sure what you mean by "proper" indenting. I think 2-space indentations and 4-space indentations are equally valid, but I personally find it uncomfortable to read code with 2-space indentations. I appreciate that you're adding a feature, but please leave the indentation and other aspects of formatting as they were. |
|
Considering indentations, I would suggest tabs instead of whitespaces, so everybody can adjust his/her editor to display indentation as desired without changing the source code. |
|
@phal0r When joining a new repository, it is typically the developers job to adapt to the coding standards and layout of the project. |
|
Yeah, I totally agree. I didn't change it, I was just suggesting a good way :) |
|
@phal0r WadJS has been updated to use tabs instead of spaces. Thanks for the suggestion. |
I've just added Wad.prototype.setPitch() (it was not possible to set pitch to single wad on playback), and tried to correct indenting in code and unify it a bit to be easily readable.