Skip to content

fix: use empty access list if eth_createAccessList returns error #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgehao merged 4 commits into from
Mar 9, 2026
Merged

fix: use empty access list if eth_createAccessList returns error #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e579aa2
fix commit tx missing StorageKeys
georgehao Mar 9, 2026
4c0b0dc
ignore access list error
Thegaram Mar 9, 2026
cfb0e13
add clarifying commit
Thegaram Mar 9, 2026
9e02a48
remove unused code
georgehao Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"runtime/debug"
)

var tag = "v4.7.12"
var tag = "v4.7.13"

var commit = func() string {
if info, ok := debug.ReadBuildInfo(); ok {
Expand Down
9 changes: 6 additions & 3 deletions rollup/internal/controller/sender/estimategas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package sender

import (
"errors"
"fmt"
"math/big"

Expand Down Expand Up @@ -134,11 +133,15 @@ func (s *Sender) estimateGasLimit(to *common.Address, data []byte, sidecar *type
accessList, gasLimitWithAccessList, errStr, rpcErr := s.gethClient.CreateAccessList(s.ctx, msg)
if rpcErr != nil {
log.Error("CreateAccessList RPC error", "error", rpcErr)
return gasLimitWithoutAccessList, nil, rpcErr
// We ignore errors from eth_createAccessList and proceed
// with sending the transaction without an access list.
return gasLimitWithoutAccessList, nil, nil
}
if errStr != "" {
// We ignore errors from eth_createAccessList and proceed
// with sending the transaction without an access list.
log.Error("CreateAccessList reported error", "error", errStr)
return gasLimitWithoutAccessList, nil, errors.New(errStr)
return gasLimitWithoutAccessList, nil, nil
}

// Fine-tune accessList because 'to' address is automatically included in the access list by the Ethereum protocol: https://github.com/ethereum/go-ethereum/blob/v1.13.10/core/state/statedb.go#L1322
Expand Down