uniform color handling between labels and points/shapes#497
Open
Sonja-Stockhaus wants to merge 4 commits intomainfrom
Open
uniform color handling between labels and points/shapes#497Sonja-Stockhaus wants to merge 4 commits intomainfrom
Sonja-Stockhaus wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 83.80% 83.83% +0.03%
==========================================
Files 8 8
Lines 1976 1980 +4
==========================================
+ Hits 1656 1660 +4
Misses 320 320
🚀 New features to boost your workflow:
|
timtreis
reviewed
Oct 20, 2025
timtreis
force-pushed
the
feature/refactor_label_color_handling
branch
2 times, most recently
from
3542f6b to
6338980
Compare
timtreis
force-pushed
the
feature/refactor_label_color_handling
branch
from
6338980 to
c31d2e9
Compare
- Use `is not None` instead of truthiness check, matching shapes/points - Pass overridden na_color to _map_color_seg so labels not in the table respect the literal color when one is set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When color is a literal value (not a column name), the groups parameter has no effect. Added a warning for labels, points, and shapes so users aren't silently confused. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract duplicated groups-ignored warning string to _GROUPS_IGNORED_WARNING - Add col_for_color guard to na_color override, matching the points pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #478, here we adapt the color handling of labels so that it works the same way as points/shapes (e.g. you can pass any color like...)