Fix Bad logic to decode the column name #1413#1424
Open
testn wants to merge 1 commit intosidorares:masterfrom
Open
Fix Bad logic to decode the column name #1413#1424testn wants to merge 1 commit intosidorares:masterfrom
testn wants to merge 1 commit intosidorares:masterfrom
Conversation
Contributor
Author
|
@sidorares this is the first attempt trying to fix #1413. It is still rough but it should demonstrate what we can address this problem. |
a717867 to
76b75e9
Compare
Owner
|
|
Contributor
Author
|
@sidorares that exposes the problem that I'm working on a fix. Basically, when you specify character_set_client, you have to encode your SQL in that encoding as well. |
Introduce character_set_results tracking to ensure that we can read the column name properly
76b75e9 to
2d7fe4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce character_set_results tracking to ensure that we can
read the column name properly
still in the draft mode