Merged
Conversation
Configure SQLCipher v4 cipher mode on Web WASM to match Desktop JVM and Android encryption format, enabling cross-platform encrypted backup portability. The Web WASM platform was using sqlite3mc's default cipher, which is incompatible with the SQLCipher v4 cipher used by the Desktop JVM (sqlite-jdbc-crypt) and Android (SafeRoom/SQLCipher). Changes: - WebDatabaseHolder: Set PRAGMA cipher='sqlcipher' and PRAGMA legacy=4 before PRAGMA key when opening encrypted DBs - WebSafeRepo: Set cipher parameters before PRAGMA rekey when encrypting an unencrypted database Co-authored-by: Artur Babichev <artik222012@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix encrypted database cross-platform incompatibility between Desktop JVM and Web WASM.
The Desktop JVM uses SQLCipher v4 mode, but the Web WASM was using sqlite3mc's default cipher, leading to "Incorrect password" errors when importing encrypted backups from Desktop to Web. This PR configures the Web WASM to also use SQLCipher v4 mode for consistent encryption across platforms.