Add support for HTTP_PROXY, HTTPS_PROXY, and NO_PROXY#1260

Open

peterguy wants to merge 31 commits intopeterguy/clean-up-configfrom

peterguy/support-http_proxy

Commits on Mar 8, 2026

add function to read HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables
peterguy
committed
use new function to read proxy settings from environment, preferring SRC_PROXY if present
peterguy
committed
use http.Request instead of manually building the request, and use Request.Write to ensure correctness
peterguy
committed
commit to a buffered reader for the proxy connection so we avoid nasty edge cases of silently dropped/ignored pieces of the response from the proxy
peterguy
committed
clone the transport TLS config instead of creating a new one, and make sure it'll try HTTP/2 by setting NextProtos
peterguy
committed
fix some comments
peterguy
committed
whoops, forgot to commit the io import
peterguy
committed
dial the proxy, ensuring http/1.1 instead of http/2 for TLS-enabled proxy
peterguy
committed
add proxy tests
peterguy
committed
change name of test to match production method
peterguy
committed
add 10ms delay to test proxy server startup to try to fix ubuntu tests
peterguy
committed
go-lint.sh
peterguy
committed
wait for test proxy to startup
peterguy
committed
go-lint.sh
peterguy
committed
parse the endpoint into a URL up front, and gather the proxy from the env up front so that typos and malformed urls will surface immediately
peterguy
committed
use the parsed endpoint url and consolidate proxy handling because the proxy in the config is now the one gathered from either SRC_PROXY or the standard env variables
peterguy
committed
fix proxyDialAddr and add more tests for it
peterguy
committed
add EndpointURL to the tests and other places that should use it instead of Endpoint
peterguy
committed
use the client to connect to the API instead of http.DefaultClient so that proxies are used
peterguy
committed
fix error message
peterguy
committed
restore unintentional whitespace changes
peterguy
committed
undo changes to search_jobs - do those changes in another PR
peterguy
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for HTTP_PROXY, HTTPS_PROXY, and NO_PROXY#1260

Add support for HTTP_PROXY, HTTPS_PROXY, and NO_PROXY#1260
peterguy wants to merge 31 commits intopeterguy/clean-up-configfrom
peterguy/support-http_proxy

Commits on Mar 8, 2026

add function to read HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables

use new function to read proxy settings from environment, preferring SRC_PROXY if present

use http.Request instead of manually building the request, and use Request.Write to ensure correctness

commit to a buffered reader for the proxy connection so we avoid nasty edge cases of silently dropped/ignored pieces of the response from the proxy

clone the transport TLS config instead of creating a new one, and make sure it'll try HTTP/2 by setting NextProtos

fix some comments

whoops, forgot to commit the io import

dial the proxy, ensuring http/1.1 instead of http/2 for TLS-enabled proxy

add proxy tests

change name of test to match production method

add 10ms delay to test proxy server startup to try to fix ubuntu tests

go-lint.sh

wait for test proxy to startup

go-lint.sh

parse the endpoint into a URL up front, and gather the proxy from the env up front so that typos and malformed urls will surface immediately

use the parsed endpoint url and consolidate proxy handling because the proxy in the config is now the one gathered from either SRC_PROXY or the standard env variables

fix proxyDialAddr and add more tests for it

add EndpointURL to the tests and other places that should use it instead of Endpoint

use the client to connect to the API instead of http.DefaultClient so that proxies are used

fix error message

restore unintentional whitespace changes

undo changes to search_jobs - do those changes in another PR

Commits on Mar 9, 2026

clarify comments and direct all proxy usage to the custom dialer

add a mutex for the buffered reader to match the concurency behavior of net.Conn.

close the connection if the TLS handshake errors

refactor to use httptest package

rename functions and address possible leaks

check I/O errors; use resp.ProtoMajor instead of strings

add test to confirm that closing the connection on handshake error (`tlsConn.Close()`) is necessary

fmt.Errorf --> errors.Newf

add test for https connection rejection - ensure correct error handling in the custom dialer