feat(trezor): add account info, compose, and broadcast FFI exports#75
feat(trezor): add account info, compose, and broadcast FFI exports#75coreyphillips wants to merge 5 commits intomasterfrom
Conversation
# Conflicts: # Cargo.lock # Cargo.toml # Package.swift # bindings/android/gradle.properties # bindings/android/lib/src/main/jniLibs/arm64-v8a/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/armeabi-v7a/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/x86/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/x86_64/libbitkitcore.so # bindings/android/lib/src/main/kotlin/com/synonym/bitkitcore/bitkitcore.android.kt # bindings/ios/BitkitCore.xcframework.zip # bindings/ios/BitkitCore.xcframework/ios-arm64-simulator/libbitkitcore.a # bindings/ios/BitkitCore.xcframework/ios-arm64/libbitkitcore.a # bindings/python/bitkitcore/libbitkitcore.dylib
|
Some of these methods in the trezor module could arguably be moved to the onchain module, but since it's only being used to wire up Trezor functionality I've decided to leave them here for now. |
|
I think there's no good reason to have methods which would be useful for any hardware integration in the Trezor module when it can be already be in onchain or separate module, and the benefit will be important later on. Is there any notable complexity or barrier to moving it out of the Trezor module? |
@ben-kaufman several methods were moved from |
This PR:
account_infomodule with BDK/Electrum queries (no device required)composemodule bridging bitkit-core account types to trezor-connect-rs offline coin selectionfetch_prev_txsto retrieve previous transactions needed for non-SegWit signingbroadcast_raw_txto broadcast signed transactions via ElectrumAccountInfoErrorerror type for blockchain query operationsScriptTypeconversion and compose FFI types(
TrezorFeeLevel,TrezorSortingStrategy,TrezorPrecomposeOutput,TrezorPrecomposeParams,TrezorPrecomposedInput,TrezorPrecomposedOutput,TrezorPrecomposedResult)New FFI exports
trezor_get_account_infotrezor_get_address_infotrezor_account_type_to_script_typetrezor_precompose_transactiontrezor_precomposed_to_sign_paramstrezor_fetch_prev_txstrezor_broadcast_raw_tx