Open
Conversation
Owner
|
Great. @chrisbaume let me know if you get a chance to test - if its before me (I wont have a chance till at least mid week next week) then great.. and ill merge if good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to bundle aac-processors as
import('sql.js')has a dependency onnode:fs. This has been resolved in sql.js (see here). This PR useswindow.initSqlJsto load the browser-specific variant of sql.js, avoiding the dependency. It passes the tests, but I've not done a real-life test using a browser yet.